Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

Send terminal events to single client #887

Merged
merged 1 commit into from
May 1, 2020
Merged

Send terminal events to single client #887

merged 1 commit into from
May 1, 2020

Conversation

GuessWhoSamFoo
Copy link
Contributor

What this PR does / why we need it:

  • Removed terminal ID and session ID because each websocket client can only have one terminal
  • Terminal should retain scrollback until a new terminal is created
  • Terminals on different browser tabs operate independently

Which issue(s) this PR fixes

@GuessWhoSamFoo GuessWhoSamFoo force-pushed the issue-842 branch 3 times, most recently from 6952b71 to d2cad28 Compare April 28, 2020 21:01
wwitzel3
wwitzel3 reviewed Apr 28, 2020
View reviewed changes
internal/api/terminal_manager.go Outdated Show resolved Hide resolved
internal/api/terminal_manager.go Outdated Show resolved Hide resolved
internal/api/terminal_manager.go Show resolved Hide resolved
internal/api/terminal_manager.go Outdated Show resolved Hide resolved
internal/api/terminal_manager.go Show resolved Hide resolved
@wwitzel3
Send terminal events to single client
972d241 
Signed-off-by: GuessWhoSamFoo <foos@vmware.com>
Co-authored-by: Wayne Witzel III <wayne@riotousliving.com>
@GuessWhoSamFoo GuessWhoSamFoo merged commit f49e3cc into vmware-archive:master May 1, 2020
@GuessWhoSamFoo GuessWhoSamFoo deleted the issue-842 branch May 1, 2020 17:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wwitzel3 wwitzel3 wwitzel3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terminal tab should not share the terminal between tabs.
2 participants
@GuessWhoSamFoo @wwitzel3