Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

Added terminal support for multiple containers #916

Merged
merged 1 commit into from
May 9, 2020

Conversation

GuessWhoSamFoo
Copy link
Contributor

@GuessWhoSamFoo GuessWhoSamFoo commented May 7, 2020

What this PR does / why we need it:
This PR adds support for command exec into multiple containers. It has the following properties in addition to those listed in #901 (comment):

  • containers in the terminated state will not be visible in the dropdown
  • a terminal opened in a new pod will default to the first container. If the user selects a different container, octant will remember that container until a terminal is opened for another pod.

Which issue(s) this PR fixes

Signed-off-by: GuessWhoSamFoo <foos@vmware.com>
@GuessWhoSamFoo GuessWhoSamFoo merged commit ae22875 into vmware-archive:master May 9, 2020
@GuessWhoSamFoo GuessWhoSamFoo deleted the issue-901 branch August 10, 2021 15:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow choosing which container to use for terminal
2 participants