-
Notifications
You must be signed in to change notification settings - Fork 480
Add --namespace-list flag to accept a slice of namespaces #928
Add --namespace-list flag to accept a slice of namespaces #928
Conversation
I can't decide if we should just extend the |
The only benefit to setting this up as a separate flag is if a user wants to provide namespaces but not necessarily start octant on any of them. I don't think that merits a different flag - going to change this |
Make sure we document that the first namespace becomes the initial/default namespace when Octant loads. |
72c0228
to
dea39b4
Compare
Ok, sorry @GuessWhoSamFoo but now I'm leaning back towards a separate flag. When I start to think about how to document this flag, there ends up being too many AND/ORs in it and it gets a little muddy. I think you had it right the first time, but maybe we call it
|
227f130
to
e646b5d
Compare
Signed-off-by: GuessWhoSamFoo <foos@vmware.com>
Rebased on master and changed flag name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this better documented, something like.
a list of namespaces to make available, if not set, Octant will attempt to list namespaces from the cluster
Signed-off-by: GuessWhoSamFoo <foos@vmware.com>
Top! thx |
Can I'd like to be able to use like this: |
That sounds like a reasonable request. Opened an issue for tracking |
@GuessWhoSamFoo I'm not sure if it's a good idea. Under the hood, --namespace-list provide a static namespace list (no rights on kubeAPI namespace list). With a feature like a wildcard... we will have to list all namespaces available (needs kubeAPI namespace list rights) and then we will apply a filter. It will be hard for a user with no rights on kubeAPI namespace list to understand why Maybe it can be something like |
What this PR does / why we need it:
Adds a
--namespace-list
flag which accepts a slice of namespaces in the form ofx,y,z
and validates each viaGet
rather thanList
for users who have restricted clusters.Which issue(s) this PR fixes