This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
use latest client-go to handle informer errors #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wayne Witzel III <wayne@riotousliving.com>
Signed-off-by: Wayne Witzel III <wayne@riotousliving.com>
Signed-off-by: Wayne Witzel III <wayne@riotousliving.com>
GuessWhoSamFoo
approved these changes
May 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wayne Witzel III wayne@riotousliving.com
What this PR does / why we need it:
Updates Octant to use the latest client-go which includes error handling callbacks for informers. This allows us to issue a
closeto the informer stop channel preventing our informer loops from spamming the API server in the event of an irrecoverable error.