Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement webhook logic on top of kubebuilder-generated webhook #38

Open
MirahImage opened this issue Mar 31, 2020 · 1 comment
Open
Labels
enhancement New feature or request estimate/M Estimated to be a medium change

Comments

@MirahImage
Copy link
Contributor

The projects-operator has a custom-built webhook that is serving CREATE project and CREATE/UPDATE projectaccess. While doing this work we created a standalone binary and manually wired it all up in our helm templating.

However it seems like kubebuilder has some pretty sweet support for webhooks, so it might be nice for us to buy into this.

Acceptance

  • project-operator acceptance tests all pass
  • we are using a kubebuilder webhook, not a custom manual one
@MirahImage MirahImage added enhancement New feature or request estimate/M Estimated to be a medium change labels Mar 31, 2020
@gmrodgers
Copy link
Contributor

The webhook supports looks pretty awesome. It provides create,update and delete methods on the api resources that will be called when the appropriate endpoint is hit to trigger the webhook. Unfortunately the abstraction covers up Request and therefore the userInfo which we use in two of our resources so we cannot move over until we can get access to these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request estimate/M Estimated to be a medium change
Projects
None yet
Development

No branches or pull requests

2 participants