Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CRD apiVersion to apiextensions.k8s.io/v1 #62

Closed
edwardecook opened this issue Apr 29, 2020 · 2 comments
Closed

Update CRD apiVersion to apiextensions.k8s.io/v1 #62

edwardecook opened this issue Apr 29, 2020 · 2 comments
Labels
enhancement New feature or request estimate/S Estimated to be a small change

Comments

@edwardecook
Copy link
Contributor

We are currently using apiextensions.k8s.io/v1beta1 as the apiVersion for our CRDs. As of k8s 1.16.0 this is deprecated and the new apiVersion is apiextensions.k8s.io/v1. See https://v1-16.docs.kubernetes.io/docs/setup/release/notes/#api-changes for a (possibly non-exhaustive list) of changes. With kubebuilder this can be accomplished by passing in crd:crdVersions=v1 to controller-gen, see https://book.kubebuilder.io/reference/controller-gen.html#generators.

Note that this would then render subsequent releases of projects-operator incompatible with versions of kubernetes before 1.16.0 so we may want to hold off on this for a little bit, although notionally only 1.16+ are currently maintained: https://kubernetes.io/docs/setup/release/version-skew-policy/#supported-versions.
@edwardecook edwardecook added enhancement New feature or request estimate/S Estimated to be a small change labels Apr 29, 2020
@edwardecook edwardecook mentioned this issue Apr 29, 2020
Open
@edwardecook
Copy link
Contributor Author

@ashwin-venkatesh @djoyahoy @matthewmcnew we'd be interested to hear your opinion on this one, we're relatively keen to adopt the v1.16.0+ features

@edwardecook
Copy link
Contributor Author

As of 457a6d0 this has been done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request estimate/S Estimated to be a small change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edwardecook