Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused/unsupported code now that the Central Repository feature is released #477

Open
marckhouzam opened this issue Sep 12, 2023 · 1 comment
Labels
kind/bug PR/issue related to a bug needs-triage

Comments

@marckhouzam
Copy link
Contributor

Bug description

After introducing the Central Repository feature, there is a lot of code paths that are no longer supported.
That code was kept as the Central Repository feature evolved, but now that it has been released, those code paths just complicate the code base for nothing.

Things that can be removed:

  • usage of context-target-v2 and no-central-repo-test-only feature flags, and all associated and unused code. The CLI does not support changing the default value of either of these feature flags.
  • unused GCP discovery source

Expected behavior

Unused/unsupported code paths are removed to simplify the code base.

@marckhouzam
Copy link
Contributor Author

A bunch of cleanup was done for v1.1.0 but there is still a bit more than can be done.
I'll keep this open for v1.2.0

@marckhouzam marckhouzam modified the milestones: v1.1.0, v1.2.0 Nov 2, 2023
@marckhouzam marckhouzam modified the milestones: v1.2.0, v1.3.0 Jan 22, 2024
@marckhouzam marckhouzam modified the milestones: v1.3.0, v1.4.0 Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug PR/issue related to a bug needs-triage
Projects
None yet
Development

No branches or pull requests

2 participants