Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better document using spec.publicUrl to access logs/backups from minIO #2256

Closed
a4nowgh opened this issue Feb 7, 2020 · 7 comments · Fixed by #2314
Closed

better document using spec.publicUrl to access logs/backups from minIO #2256

a4nowgh opened this issue Feb 7, 2020 · 7 comments · Fixed by #2314

Comments

@a4nowgh
Copy link

a4nowgh commented Feb 7, 2020

What steps did you take and what happened:
[A clear and concise description of what the bug is, and what commands you ran.)
This occurs after when using minIO storage location.

velero backup create --storage-location <minIO_storage>

velero backup describe --details

Output:
Request List: request failed: garbled special characters/encoding repeat repeat etc...

The rest of the output looks OK

NOTE: I am able to perform successful restores with this backup

What did you expect to happen:
Show Request List

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Resource lists from backups to my other non-minIO S3-Compliant bucket display OK

Environment:

  • minIO Version: 2019-04-17T17:41:56Z
  • minIO Release-tag: RELEASE.2019-04-17T17-41-56Z
  • Velero version: v1.2.0
  • Velero features:
  • Kubernetes Client version: v1.15.3
  • Kubernetes Server version: v1.14.6
  • Cloud provider or hardware configuration: aws
  • OS: Ubuntu 18.04.3 LTS
@carlisia
Copy link
Contributor

carlisia commented Feb 8, 2020

Hm this is odd. Mind dumping the actual output, it might be helpful to see.

Is this an on-prem cluster you are backing up?

@a4nowgh
Copy link
Author

a4nowgh commented Feb 8, 2020 via email

@nrb
Copy link
Contributor

nrb commented Feb 10, 2020

@a4nowgh Are you using https on your Minio installation?

@a4nowgh
Copy link
Author

a4nowgh commented Feb 10, 2020 via email

@nrb
Copy link
Contributor

nrb commented Feb 10, 2020

Here's my guess - the Velero client is using your BackupStorageLocation's spec.config.s3url, which is an https URL, and getting the encrypted contents. If you add an http URL to spec.config.publicUrl, the velero client should be able to download the resource list in readable format.

If my suspicion is correct, then the velero restore logs and velero backup logs commands should also return encrypted values.

The reason this happens is that with AWS S3 buckets, Velero requests 1-time use signed URLs for downloads. Minio doesn't support this, so a workaround is to use the publicURL config value.

This used to be documented, but appears to have been dropped as things have moved around. I'll get a PR in for it. The closest we have right now is https://velero.io/docs/v1.2.0/contributions/minio/#work-with-ingress.

@a4nowgh
Copy link
Author

a4nowgh commented Feb 10, 2020 via email

@skriss skriss changed the title Resource List is garbled in backup describe output better document using spec.publicUrl to access logs/backups from minIO Feb 18, 2020
@nrb
Copy link
Contributor

nrb commented May 12, 2020

@a4nowgh Did you change your Minio installation to use HTTP only, or did you add a HTTP endpoint?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants