Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question regarinding SSL and custom CAs #2304

Closed
aceeric opened this issue Feb 27, 2020 · 3 comments
Closed

Question regarinding SSL and custom CAs #2304

aceeric opened this issue Feb 27, 2020 · 3 comments
Labels
Security Security related issues

Comments

@aceeric
Copy link

aceeric commented Feb 27, 2020

Folks, I've seen a couple discussion threads regarding velero/restic against an S3 provider that requires SSL with custom a CA, and therefore needing to override the default system CA. This is our use case. We use rook-ceph as our S3 provider and we have a custom CA that is a corporate resource. We configure rook-ceph to provide a cert that is validated by this CA.

Based on this documentation -- https://golang.org/pkg/crypto/x509/ -- it looks like the go runtime honors the SSL_CERT_FILE environment variable. So I configured our velero deployment and restic daemonset manifests to mount our CA from a secret and then I set SSL_CERT_FILE to point to that mounted CA in the deployment and daemonset.

I've tested and so for this seems to work fine. Do you see anything fragile or subject to future breakage from this approach? Thanks.

@ashish-amarnath ashish-amarnath added Enhancement/User End-User Enhancement to Velero Security Security related issues labels Feb 27, 2020
@ashish-amarnath
Copy link
Contributor

Not the same, but kinda related to #2259 and therefore #1027

@ashish-amarnath ashish-amarnath added Question and removed Enhancement/User End-User Enhancement to Velero labels Feb 27, 2020
@ashish-amarnath
Copy link
Contributor

This seems like an acceptable solution short term. However, the issue I see with this approach is that, by setting the SSL_CERT_FILE environment variable, we will be forcing this ca cert to be used for all ssl connections. This can become a problem if you are trying to connect to multiple endpoints which may not recognize the corporate ca cert. This also applies to the other velero plugins that you may have as part of your deployment.

@ashish-amarnath
Copy link
Contributor

@aceeric I am going to mark this question as answered and close this out.
Feel free to reach out if we can help out further!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Security Security related issues
Projects
None yet
Development

No branches or pull requests

2 participants