Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

?Do we want to continue halting when trying to disable a controller that doesn't exist in the disableable list #2889

Closed
carlisia opened this issue Sep 1, 2020 · 2 comments
Labels
Enhancement/User End-User Enhancement to Velero Needs investigation

Comments

@carlisia
Copy link
Contributor

carlisia commented Sep 1, 2020

When a user passes in a configuration setting to disable a controller, and that setting does not match the controller name of one of the disableable controllers, the server logs with a Fatalf.

The question is: do we want to continue this behavior? Or is this too austere?

Discussion thread:
#2838 (comment)

@nrb
Copy link
Contributor

nrb commented Oct 23, 2020

I vote yes - the user should be notified that they are trying to disable something that doesn't exist.

If we don't halt, then we end up running a controller that they didn't want, because it wasn't matched against the incorrectly-entered name.

@ashish-amarnath
Copy link
Contributor

@nrb That's a fair point.
I am going to close this issue as resolved as this came out from a discussion that I started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement/User End-User Enhancement to Velero Needs investigation
Projects
None yet
Development

No branches or pull requests

3 participants