馃悰 Fix plugin name derivation from image name #3711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/kind changelog-not-required |
github-actions
bot
added
the
kind/changelog-not-required
|
The issue this PR fixes has been reported here: #3715. |
zubron
suggested changes
Apr 21, 2021
There was a problem hiding this comment.
This looks good, thanks for addressing it so quickly, @ashish-amarnath! Given that this has been reported by a community member (#3715) and is a bug, I think it should have a changelog.
ashish-amarnath
removed
the
kind/changelog-not-required
pradeep288
reviewed
Apr 21, 2021
ashish-amarnath
force-pushed
the
plugin-name-fix
branch
from
31142dc
to
3cdf5e4
Compare
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
ashish-amarnath
force-pushed
the
plugin-name-fix
branch
from
3cdf5e4
to
4728ed8
Compare
carlisia
approved these changes
Apr 22, 2021
ashish-amarnath
moved this from Review in progress
to Reviewer approved
in Velero Sprint 04-19-2021
carlisia
moved this from Reviewer approved
to Review in progress
in Velero Sprint 04-19-2021
Velero Sprint 04-19-2021
automation
moved this from Review in progress
to Reviewer approved
Apr 22, 2021
zubron
pushed a commit
to zubron/velero
that referenced
this pull request
Jun 21, 2021
* 馃悰 Fix plugin name derivation from image name Signed-off-by: Ashish Amarnath <ashisham@vmware.com> * changelog Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
ywk253100
pushed a commit
to ywk253100/velero
that referenced
this pull request
Jun 29, 2021
* 馃悰 Fix plugin name derivation from image name Signed-off-by: Ashish Amarnath <ashisham@vmware.com> * changelog Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
gyaozhou
pushed a commit
to gyaozhou/velero-read
that referenced
this pull request
May 14, 2022
* 馃悰 Fix plugin name derivation from image name Signed-off-by: Ashish Amarnath <ashisham@vmware.com> * changelog Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ashish Amarnath ashisham@vmware.com
Thank you for contributing to Velero!
Plugin's init container name is derived from the plugin's image that is supplied in the
velero plugin addcommand.This derivation is a concatenation of image's repository name, and the image name. Further replacing characters that are allowed in container images repository name but not in a valid RFC-1123 label. Specifically, the container image repository name matches the regex
[a-z0-9]+(?:[._-][a-z0-9]+)*. However, valid RFC-1123 labels should not have_or..This PR replaces
_and.with-making the derived name RFC-1123 compliant.Does your change fix a particular issue?
Fixes #3715
Please indicate you've done the following:
/kind changelog-not-required.site/content/docs/main.