Support pulling plugins by digest #3803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `WithPlugins` only supported passing image URIs "by tag" -- e.g. `gcr.io/my-repo/my-image:v0.1.2`. With this commit, we add support for pulling "by digest" -- e.g. `gcr.io/my-repo/my-image@sha256:a75f9e8c3ced3943515f249597be389f8233e1258d289b11184796edceaa7dab` Signed-off-by: Eric Fried <efried@redhat.com>
2uasimojo
force-pushed
the
plugins-by-digest
branch
from
29acda4
to
131d543
Compare
|
/retest |
jenting
approved these changes
May 18, 2021
ywk253100
pushed a commit
to ywk253100/velero
that referenced
this pull request
Jun 29, 2021
Previously `WithPlugins` only supported passing image URIs "by tag" -- e.g. `gcr.io/my-repo/my-image:v0.1.2`. With this commit, we add support for pulling "by digest" -- e.g. `gcr.io/my-repo/my-image@sha256:a75f9e8c3ced3943515f249597be389f8233e1258d289b11184796edceaa7dab` Signed-off-by: Eric Fried <efried@redhat.com>
gyaozhou
pushed a commit
to gyaozhou/velero-read
that referenced
this pull request
May 14, 2022
Previously `WithPlugins` only supported passing image URIs "by tag" -- e.g. `gcr.io/my-repo/my-image:v0.1.2`. With this commit, we add support for pulling "by digest" -- e.g. `gcr.io/my-repo/my-image@sha256:a75f9e8c3ced3943515f249597be389f8233e1258d289b11184796edceaa7dab` Signed-off-by: Eric Fried <efried@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
WithPluginsonly supported passing image URIs "by tag" -- e.g.gcr.io/my-repo/my-image:v0.1.2. With this commit, we add support for pulling "by digest" -- e.g.gcr.io/my-repo/my-image@sha256:a75f9e8c3ced3943515f249597be389f8233e1258d289b11184796edceaa7dabSigned-off-by: Eric Fried efried@redhat.com
Thank you for contributing to Velero!
Please add a summary of your change
Previously
WithPluginsonly supported passing image URIs "by tag" -- e.g.gcr.io/my-repo/my-image:v0.1.2. With this commit, we add support for pulling "by digest" -- e.g.gcr.io/my-repo/my-image@sha256:a75f9e8c3ced3943515f249597be389f8233e1258d289b11184796edceaa7dabDoes your change fix a particular issue?
Using velero under OpenShift with ImageContentSourcePolicy it is necessary to reference images by digest rather than by tag.
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-required.site/content/docs/main.(n/a, I think)