Fix -install-velero flag for e2e tests #3919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaidevmane
changed the title
jaidevmane
changed the title
jaidevmane
changed the title
Signed-off-by: Jai Subash Devmane <jdevmane@redhat.com>
jaidevmane
force-pushed
the
installVeleroFix
branch
from
3060c18
to
db375f3
Compare
jaidevmane
changed the title
|
LGTM. Please note this PR will be void if #3888 is merged as is. It's likely untenable for each test to have to maintain the I will bring this up on the community call next week and figure out what the plan is to move forward. |
ywk253100
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
1.adding install flag to test makefile
2.fixing bug where velero was being uninstalled in the APIGroup test even though the -install-velero flag was set to false
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-required.site/content/docs/main.