Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable e2e tests to choose crd apiVersion #3941

Merged
merged 1 commit into from Jul 28, 2021

Conversation

sseago
Copy link
Collaborator

@sseago sseago commented Jul 9, 2021

Signed-off-by: Scott Seago sseago@redhat.com

Thank you for contributing to Velero!

Please add a summary of your change

Enables running e2e tests with either v1 or v1beta1 CRDs

Please indicate you've done the following:

@sseago
Copy link
Collaborator Author

sseago commented Jul 9, 2021

Note that this PR depends on https://github.com/vmware-tanzu/velero/pull/3614/files to be merged first.

@sseago
Copy link
Collaborator Author

sseago commented Jul 9, 2021

The "Run the E2E test" checks are expected to fail right now, since some of the required code is not yet merged.

@ywk253100 ywk253100 added this to the v1.6.3 milestone Jul 21, 2021
@ywk253100 ywk253100 self-requested a review July 21, 2021 08:05
@jenting
Copy link
Contributor

jenting commented Jul 28, 2021

#3614 PR merged, please help rebase it :)

dsu-igeek
dsu-igeek previously approved these changes Jul 28, 2021
Copy link
Contributor

@dsu-igeek dsu-igeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@jenting
Copy link
Contributor

jenting commented Jul 28, 2021

/rebase

@zubron
Copy link
Contributor

zubron commented Jul 28, 2021

@sseago Could you please run make update and push the changes? Thanks! I tried to do it myself but I don't have permission to push to this branch.

Signed-off-by: Scott Seago <sseago@redhat.com>
@sseago
Copy link
Collaborator Author

sseago commented Jul 28, 2021

@zubron On it. Will push an update shortly.

Copy link
Contributor

@zubron zubron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zubron zubron requested a review from dsu-igeek July 28, 2021 22:15
@ywk253100 ywk253100 merged commit 6ac2122 into vmware-tanzu:main Jul 28, 2021
zubron pushed a commit to zubron/velero that referenced this pull request Jul 29, 2021
enable e2e tests to choose crd apiVersion
jenting pushed a commit that referenced this pull request Jul 29, 2021
* Merge pull request #3941 from sseago/e2e-crdversion

enable e2e tests to choose crd apiVersion

* Updated uninstall to remove both v1beta1 and v1 CRDs if present (#3997)

* Add changelog for v1.6.3

Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>

Co-authored-by: Wenkai Yin(尹文开) <yinw@vmware.com>
Co-authored-by: David L. Smith-Uchida <dsmithuchida@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants