Verify group before treating resource as cohabitating #4126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott Seago <sseago@redhat.com>
sseago
force-pushed
the
cohabitating-fix
branch
from
f28f2d1
to
fd7c05a
Compare
|
@alaypatel07 This is the fix we were discussing earlier. |
ywk253100
approved these changes
Sep 13, 2021
|
Will finish review and merge after 1.7 RC2 |
zubron
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Scott Seago sseago@redhat.com
Thank you for contributing to Velero!
Please add a summary of your change
This PR adds group checking to the cohabitating resource handling. Before setting cohabitator.seen or checking for cohabitator.seen, we first confirm that this resource belongs to one of the linked groups.
Also included is a unit test which confirms the fix.
Does your change fix a particular issue?
Fixes #4125
Please indicate you've done the following:
/kind changelog-not-required.site/content/docs/main.