Refine tag-release.sh #4185
Merged
Refine tag-release.sh #4185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes several changes to `tag-release.sh` according to the change in release process: 1. It will support a "ON_RELEASE_BRANCH" param passed via env variable. When it's set to "TRUE". The release will be created on the commit of branch like `release-xxx`. This enables us to create release branch before GA and tag RC release. 2. It removes the code to push a new branch to upstream. This is because we decided to create branch manually. For patch releases, we will not push the change to release branch, instead, we will make sure the release branch has all commits cherrypicked BEFORE we run this script to tag the release. After the change the script will focus on only tag the release, not making other code change to release branches. Signed-off-by: Daniel Jiang <jiangd@vmware.com>
reasonerjt
force-pushed
the
update-release-script
branch
from
c32524c
to
d08c4ba
Compare
|
@zubron |
|
@reasonerjt Yes, that seems fine to me since this script checks out the release branch as it runs 👍 |
zubron
approved these changes
Sep 22, 2021
reasonerjt
added
the
kind/release-blocker
ywk253100
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes several changes to
tag-release.shaccording to thechange in release process:
When it's set to "TRUE". The release will be created on the commit of
branch like
release-xxx. This enables us to create release branchbefore GA and tag RC release.
because we decided to create branch manually. For patch releases, we
will not push the change to release branch, instead, we will make
sure the release branch has all commits cherrypicked BEFORE we run
this script to tag the release.
After the change the script will focus on only tag the release, not
making other code change to release branches.
Signed-off-by: Daniel Jiang jiangd@vmware.com
Thank you for contributing to Velero!
Fixes #4174
Please indicate you've done the following:
/kind changelog-not-required.site/content/docs/main.