Only set BSL credential field if provided #4322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the BSL credential field would always be set when using the `create` command, even if no credential details were provided. This would result in an empty `SecretKeySelector` in the BSL which would cause operations using this BSL to fail as Velero would attempt to fetch a `Secret` with an empty name from the K8s API server. With this change, the `Credential` field is only set if credential details have been specified. This change also includes some refactoring to allow the change to be tested. Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
zubron
force-pushed
the
fix-setting-empty-credential-field-in-bsl-4196
branch
from
c3d6778
to
6e2daa1
Compare
jenting
approved these changes
Nov 9, 2021
| setErr := o.Credential.Set("my-secret=key-from-secret") | ||
| assert.NoError(t, setErr) | ||
|
|
||
| bsl, err = o.BuildBackupStorageLocation("velero-test-ns", false, true) |
There was a problem hiding this comment.
nit:
bsl, err = o.BuildBackupStorageLocation("velero-test-ns", false, false)
sseago
approved these changes
Nov 9, 2021
danfengliu
pushed a commit
to danfengliu/velero
that referenced
this pull request
Jan 25, 2022
Previously, the BSL credential field would always be set when using the `create` command, even if no credential details were provided. This would result in an empty `SecretKeySelector` in the BSL which would cause operations using this BSL to fail as Velero would attempt to fetch a `Secret` with an empty name from the K8s API server. With this change, the `Credential` field is only set if credential details have been specified. This change also includes some refactoring to allow the change to be tested. Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
gyaozhou
pushed a commit
to gyaozhou/velero-read
that referenced
this pull request
May 14, 2022
Previously, the BSL credential field would always be set when using the `create` command, even if no credential details were provided. This would result in an empty `SecretKeySelector` in the BSL which would cause operations using this BSL to fail as Velero would attempt to fetch a `Secret` with an empty name from the K8s API server. With this change, the `Credential` field is only set if credential details have been specified. This change also includes some refactoring to allow the change to be tested. Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add a summary of your change
Previously, the BSL credential field would always be set when using the
createcommand, even if no credential details were provided. Thiswould result in an empty
SecretKeySelectorin the BSL which wouldcause operations using this BSL to fail as Velero would attempt to fetch
a
Secretwith an empty name from the K8s API server.With this change, the
Credentialfield is only set if credentialdetails have been specified. This change also includes some refactoring
to allow the change to be tested.
Signed-off-by: Bridget McErlean bmcerlean@vmware.com
Does your change fix a particular issue?
Fixes #4196
Please indicate you've done the following:
/kind changelog-not-required.site/content/docs/main.