fix: modify generated from schedule's backup name timestamp to UTC ti… #4353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mezone fix vmware-tanzu#4279 When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name. Signed-off-by: Xun Jiang <jxun@vmware.com>
…mezone fix vmware-tanzu#4279 When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name. Signed-off-by: Xun Jiang <jxun@vmware.com>
blackpiglet
force-pushed
the
4279-change-generated-backup-name-timestamp-to-utc-updated
branch
from
9a3be35
to
b68ec79
Compare
jenting
reviewed
Nov 16, 2021
changelogs/unreleased/4353-jxun
Outdated
Comment on lines
1
to
5
| Modify generated from schedule's backup name timestamp to UTC timestamp. | ||
| Fix https://github.com/vmware-tanzu/velero/issues/4279 | ||
| When backup is created from schedule, and the backup name is not specified, | ||
| a containing-timestamp generated name will be used. | ||
| Due to velero client not set timezone to UTC, a local timezone will be used for the generated name. |
There was a problem hiding this comment.
Suggested change
| Modify generated from schedule's backup name timestamp to UTC timestamp. | |
| Fix https://github.com/vmware-tanzu/velero/issues/4279 | |
| When backup is created from schedule, and the backup name is not specified, | |
| a containing-timestamp generated name will be used. | |
| Due to velero client not set timezone to UTC, a local timezone will be used for the generated name. | |
| Modify generated from schedule's backup name timestamp to UTC timestamp. |
You don't have to link the issue on the changelog file, it will be auto-generated and linked in the release node.
There was a problem hiding this comment.
Thanks. Updated according to comment.
…mezone fix vmware-tanzu#4279 When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name. Signed-off-by: Xun Jiang <jxun@vmware.com>
blackpiglet
force-pushed
the
4279-change-generated-backup-name-timestamp-to-utc-updated
branch
from
e9c17cb
to
2f22c97
Compare
jglick
reviewed
Nov 16, 2021
changelogs/unreleased/4353-jxun
Outdated
| @@ -0,0 +1 @@ | |||
| Modify generated from schedule's backup name timestamp to UTC timestamp. | |||
There was a problem hiding this comment.
Apostrophe possessive is awkward in English for multi-word phrases. Perhaps
Suggested change
| Modify generated from schedule's backup name timestamp to UTC timestamp. | |
| Modify the timestamp in the name of a backup generated from schedule to use UTC. |
There was a problem hiding this comment.
Thanks. I'll reword it.
Reword the changelog description according to comments. Signed-off-by: Xun Jiang <jxun@vmware.com>
blackpiglet
force-pushed
the
4279-change-generated-backup-name-timestamp-to-utc-updated
branch
from
01b0379
to
24742e9
Compare
jenting
approved these changes
Nov 17, 2021
qiuming-best
pushed a commit
to qiuming-best/velero
that referenced
this pull request
Nov 22, 2021
vmware-tanzu#4353) * fix: modify generated from schedule's backup name timestamp to UTC timezone fix vmware-tanzu#4279 When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name. Signed-off-by: Xun Jiang <jxun@vmware.com> * fix: modify generated from schedule's backup name timestamp to UTC timezone fix vmware-tanzu#4279 When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name. Signed-off-by: Xun Jiang <jxun@vmware.com> * fix: modify generated from schedule's backup name timestamp to UTC timezone fix vmware-tanzu#4279 When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name. Signed-off-by: Xun Jiang <jxun@vmware.com> * modify changelog description Reword the changelog description according to comments. Signed-off-by: Xun Jiang <jxun@vmware.com> Co-authored-by: jxun <jxun@jxun-a01.vmware.com> Co-authored-by: Xun Jiang <jxun@vmware.com>
qiuming-best
pushed a commit
to qiuming-best/velero
that referenced
this pull request
Nov 22, 2021
vmware-tanzu#4353) * fix: modify generated from schedule's backup name timestamp to UTC timezone fix vmware-tanzu#4279 When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name. Signed-off-by: Xun Jiang <jxun@vmware.com> * fix: modify generated from schedule's backup name timestamp to UTC timezone fix vmware-tanzu#4279 When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name. Signed-off-by: Xun Jiang <jxun@vmware.com> * fix: modify generated from schedule's backup name timestamp to UTC timezone fix vmware-tanzu#4279 When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name. Signed-off-by: Xun Jiang <jxun@vmware.com> * modify changelog description Reword the changelog description according to comments. Signed-off-by: Xun Jiang <jxun@vmware.com> Co-authored-by: jxun <jxun@jxun-a01.vmware.com> Co-authored-by: Xun Jiang <jxun@vmware.com>
danfengliu
pushed a commit
to danfengliu/velero
that referenced
this pull request
Jan 25, 2022
vmware-tanzu#4353) * fix: modify generated from schedule's backup name timestamp to UTC timezone fix vmware-tanzu#4279 When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name. Signed-off-by: Xun Jiang <jxun@vmware.com> * fix: modify generated from schedule's backup name timestamp to UTC timezone fix vmware-tanzu#4279 When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name. Signed-off-by: Xun Jiang <jxun@vmware.com> * fix: modify generated from schedule's backup name timestamp to UTC timezone fix vmware-tanzu#4279 When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name. Signed-off-by: Xun Jiang <jxun@vmware.com> * modify changelog description Reword the changelog description according to comments. Signed-off-by: Xun Jiang <jxun@vmware.com> Co-authored-by: jxun <jxun@jxun-a01.vmware.com> Co-authored-by: Xun Jiang <jxun@vmware.com>
gyaozhou
pushed a commit
to gyaozhou/velero-read
that referenced
this pull request
May 14, 2022
vmware-tanzu#4353) * fix: modify generated from schedule's backup name timestamp to UTC timezone fix vmware-tanzu#4279 When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name. Signed-off-by: Xun Jiang <jxun@vmware.com> * fix: modify generated from schedule's backup name timestamp to UTC timezone fix vmware-tanzu#4279 When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name. Signed-off-by: Xun Jiang <jxun@vmware.com> * fix: modify generated from schedule's backup name timestamp to UTC timezone fix vmware-tanzu#4279 When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name. Signed-off-by: Xun Jiang <jxun@vmware.com> * modify changelog description Reword the changelog description according to comments. Signed-off-by: Xun Jiang <jxun@vmware.com> Co-authored-by: jxun <jxun@jxun-a01.vmware.com> Co-authored-by: Xun Jiang <jxun@vmware.com>
blackpiglet
deleted the
4279-change-generated-backup-name-timestamp-to-utc-updated
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mezone
fix #4279
When backup is created from schedule, and the backup name is not specified, a containing-timestamp generated name will be used. Due to velero client not set timezone to UTC, a local timezone will be used for the generated name.
Signed-off-by: Xun Jiang jxun@vmware.com
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-required.site/content/docs/main.