-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix statefulsets volumeClaimTemplates storageClassName after use Changing PV/PVC Storage Classes #4375
Conversation
…ging PV/PVC Storage Classes Signed-off-by: Box-Cube <64300761+Box-Cube@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change should be made in the plugin ChangeStorageClassAction
, not in the restore flow
But ChangeStorageClassAction execute for the kind PersistentVolumeClaim object, It seems unlikely that the StatefulSet storageclassName can be changed in ChangeStorageClassAction. |
We can extend the |
Signed-off-by: Box-Cube <64300761+Box-Cube@users.noreply.github.com>
Signed-off-by: Box-Cube <64300761+Box-Cube@users.noreply.github.com>
Signed-off-by: Box-Cube <64300761+Box-Cube@users.noreply.github.com>
Signed-off-by: Box-Cube <64300761+Box-Cube@users.noreply.github.com>
Signed-off-by: Box-Cube <64300761+Box-Cube@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
@Box-Cube Could you please take a look at the CI checking failure? |
Signed-off-by: Box-Cube <64300761+Box-Cube@users.noreply.github.com>
The previous commit did not follow the community import format,now has been modified. |
Dismissing the request to change as the submitter has refined it based on my comment
…ging PV/PVC Storage Classes (vmware-tanzu#4375) * fix statefulsets volumeClaimTemplates storageClassName after use Changing PV/PVC Storage Classes Signed-off-by: Box-Cube <64300761+Box-Cube@users.noreply.github.com> * Fix (vmware-tanzu#4373) Signed-off-by: Box-Cube <64300761+Box-Cube@users.noreply.github.com> * Fix StatefulSet volumeClaimTemplates storageClassName(vmware-tanzu#4373) Signed-off-by: Box-Cube <64300761+Box-Cube@users.noreply.github.com> * Fix StatefulSet volumeClaimTemplates storageClassName(vmware-tanzu#4373) Signed-off-by: Box-Cube <64300761+Box-Cube@users.noreply.github.com> * Fix StatefulSet volumeClaimTemplates storageClassName(vmware-tanzu#4373) Signed-off-by: Box-Cube <64300761+Box-Cube@users.noreply.github.com> * Change the isStorageClassExist logic Signed-off-by: Box-Cube <64300761+Box-Cube@users.noreply.github.com> * Fix StatefulSet volumeClaimTemplates storageClassName(vmware-tanzu#4373) Signed-off-by: Box-Cube <64300761+Box-Cube@users.noreply.github.com>
…ging PV/PVC Storage Classes (vmware-tanzu#4375) * fix statefulsets volumeClaimTemplates storageClassName after use Changing PV/PVC Storage Classes Signed-off-by: Box-Cube <64300761+Box-Cube@users.noreply.github.com> * Fix (vmware-tanzu#4373) Signed-off-by: Box-Cube <64300761+Box-Cube@users.noreply.github.com> * Fix StatefulSet volumeClaimTemplates storageClassName(vmware-tanzu#4373) Signed-off-by: Box-Cube <64300761+Box-Cube@users.noreply.github.com> * Fix StatefulSet volumeClaimTemplates storageClassName(vmware-tanzu#4373) Signed-off-by: Box-Cube <64300761+Box-Cube@users.noreply.github.com> * Fix StatefulSet volumeClaimTemplates storageClassName(vmware-tanzu#4373) Signed-off-by: Box-Cube <64300761+Box-Cube@users.noreply.github.com> * Change the isStorageClassExist logic Signed-off-by: Box-Cube <64300761+Box-Cube@users.noreply.github.com> * Fix StatefulSet volumeClaimTemplates storageClassName(vmware-tanzu#4373) Signed-off-by: Box-Cube <64300761+Box-Cube@users.noreply.github.com>
Signed-off-by: Box-Cube 64300761+Box-Cube@users.noreply.github.com
Thank you for contributing to Velero!
Please add a summary of your change
Change STS volumeClaimTemplates storageClassName to the new storageClass when using Changing PV/PVC Storage Classes function.
Does your change fix a particular issue?
Fixes #4373
Please indicate you've done the following: