Remove backups and restic repos associated with deleted BSL(s) #4377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenting
reviewed
Nov 21, 2021
ywk253100
reviewed
Nov 23, 2021
ywk253100
reviewed
Nov 23, 2021
dsu-igeek
suggested changes
Nov 24, 2021
Signed-off-by: F. Gold <fgold@vmware.com>
Signed-off-by: F. Gold <fgold@vmware.com>
Signed-off-by: F. Gold <fgold@vmware.com>
…errors Signed-off-by: F. Gold <fgold@vmware.com>
codegold79
force-pushed
the
2082-delete-associated-backup-and-restic-repos-when-bsl-deleted
branch
from
aa30a4d
to
b6575f5
Compare
danfengliu
pushed a commit
to danfengliu/velero
that referenced
this pull request
Jan 25, 2022
…e-tanzu#4377) * Remove backups and restic repos associated with deleted BSL(s) Signed-off-by: F. Gold <fgold@vmware.com> * add changelog Signed-off-by: F. Gold <fgold@vmware.com> * Add PR number to changelog Signed-off-by: F. Gold <fgold@vmware.com> * Fix typo Signed-off-by: F. Gold <fgold@vmware.com> * Only delete backups and restic repos and report success when without errors Signed-off-by: F. Gold <fgold@vmware.com>
gyaozhou
pushed a commit
to gyaozhou/velero-read
that referenced
this pull request
May 14, 2022
…e-tanzu#4377) * Remove backups and restic repos associated with deleted BSL(s) Signed-off-by: F. Gold <fgold@vmware.com> * add changelog Signed-off-by: F. Gold <fgold@vmware.com> * Add PR number to changelog Signed-off-by: F. Gold <fgold@vmware.com> * Fix typo Signed-off-by: F. Gold <fgold@vmware.com> * Only delete backups and restic repos and report success when without errors Signed-off-by: F. Gold <fgold@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: F. Gold fgold@vmware.com
Summary of change
Added cli logic to look for backups and restic repositories that have the
velero.io/storage-location=<deleted-bsl-name>label. The Velero client will then delete those backup and restic repos.Regarding tests, I added expectations in @danfengliu's test cases plan where a BSL is deleted (I believe the test case documentation will be published to this Velero repo soon, after it's completed).
I looked for documentation to change, but there is nothing mentioned about deleting BSLs and so nothing to update.
Change fixes an issue
Fixes #2082
Please indicate you've done the following:
/kind changelog-not-required.site/content/docs/main.