Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust structure of e2e test codes #4386

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

qiuming-best
Copy link
Contributor

Put every test moduels into seperate packages and all velero install parameters integrated into one struct
Signed-off-by: Ming mqiu@vmware.com

Thank you for contributing to Velero!

Please add a summary of your change

It's reference to #4349, but it's just optimize the e2e codes structure, the new test cases codes will be submitted in another pr.

  • Putting different test modules into separate packages, so categorize test cases may make our test codes structure more clear.(which reference to the kubernates e2e code structure)
  • Integrating all velero install options parameters into one struct.

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

Put every test moduels into seperate packages and all velero install parameters integrated into one struct

Signed-off-by: Ming <mqiu@vmware.com>
Copy link
Contributor

@danfengliu danfengliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ywk253100 ywk253100 merged commit 04cfadf into vmware-tanzu:main Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants