Consolidated code for resolving actions and plugins into ActionResolver #4410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsu-igeek
force-pushed
the
dsu-action-resolver-rebase-11-29-2021
branch
from
4859ecf
to
3c3689a
Compare
dsu-igeek
requested review from
zubron and
reasonerjt
and removed request for
sseago and
ywk253100
dsu-igeek
force-pushed
the
dsu-action-resolver-rebase-11-29-2021
branch
from
3c3689a
to
b3d2175
Compare
…er. Added BackupWithResolvers and RestoreWithResolvers. Introduces ItemSnapshooterResolver to bring ItemSnapshotter plugins into backup and restore. ItemSnapshotters are not used yet. Added action_resolver_test Signed-off-by: Dave Smith-Uchida <dsmithuchida@vmware.com>
dsu-igeek
force-pushed
the
dsu-action-resolver-rebase-11-29-2021
branch
from
b3d2175
to
cb964b7
Compare
reasonerjt
reviewed
Dec 3, 2021
| resolvedAction | ||
| } | ||
|
|
||
| func (recv DeleteItemResolvedAction) GetApplicable() velero.Applicable { |
There was a problem hiding this comment.
See comments for BackupItemResolveAction
Signed-off-by: Dave Smith-Uchida <dsmithuchida@vmware.com>
dsu-igeek
force-pushed
the
dsu-action-resolver-rebase-11-29-2021
branch
from
999d3be
to
3740d53
Compare
danfengliu
pushed a commit
to danfengliu/velero
that referenced
this pull request
Jan 25, 2022
…er (vmware-tanzu#4410) * Consolidated code for resolving actions and plugins into ActionResolver. Added BackupWithResolvers and RestoreWithResolvers. Introduces ItemSnapshooterResolver to bring ItemSnapshotter plugins into backup and restore. ItemSnapshotters are not used yet. Added action_resolver_test Signed-off-by: Dave Smith-Uchida <dsmithuchida@vmware.com> * Addressed review comments Signed-off-by: Dave Smith-Uchida <dsmithuchida@vmware.com>
gyaozhou
pushed a commit
to gyaozhou/velero-read
that referenced
this pull request
May 14, 2022
…er (vmware-tanzu#4410) * Consolidated code for resolving actions and plugins into ActionResolver. Added BackupWithResolvers and RestoreWithResolvers. Introduces ItemSnapshooterResolver to bring ItemSnapshotter plugins into backup and restore. ItemSnapshotters are not used yet. Added action_resolver_test Signed-off-by: Dave Smith-Uchida <dsmithuchida@vmware.com> * Addressed review comments Signed-off-by: Dave Smith-Uchida <dsmithuchida@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidated code for resolving actions and plugins into ActionResolver. Added BackupWithResolvers and
RestoreWithResolvers. Introduces ItemSnapshooterResolver to bring ItemSnapshotter plugins into backup and
restore. ItemSnapshotters are not used yet.
Signed-off-by: Dave Smith-Uchida dsmithuchida@vmware.com
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-required.site/content/docs/main.