Limit backup namespaces on test resource filtering cases #4437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiuming-best
requested review from
ywk253100 and
danfengliu
and removed request for
sseago and
reasonerjt
Signed-off-by: ming qiu <mqiu@mqiu-a01.vmware.com>
qiuming-best
force-pushed
the
resource-filtering
branch
from
87b9fcd
to
c58fc14
Compare
qiuming-best
commented
Dec 9, 2021
| if VeleroCfg.InstallVelero { | ||
| err := VeleroUninstall(context.Background(), VeleroCfg.VeleroCLI, VeleroCfg.VeleroNamespace) | ||
| Expect(err).To(Succeed()) | ||
| isVeleroInstalled = true | ||
| } |
There was a problem hiding this comment.
Here, In the cases which call the TestFunc will only install velero once, but will not uninstall it when complete. Later I will further improve in other modules.
ywk253100
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ming qiu mqiu@mqiu-a01.vmware.com
Thank you for contributing to Velero!
Please add a summary of your change
Fix two problems in vsphere e2e environment.
Does your change fix a particular issue?
Fixes #(issue)
#4404
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.