Return the error when getting backup store in backup deletion controller #4465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reasonerjt
force-pushed
the
del-backup-ctl-getting-backupstore-err
branch
from
8735e57
to
f1a0bc3
Compare
Per discussion in vmware-tanzu#4260 (comment) vmware-tanzu#4260 (comment) return the error to avoid a panic when downloading the backup tarball Signed-off-by: Daniel Jiang <jiangd@vmware.com>
reasonerjt
force-pushed
the
del-backup-ctl-getting-backupstore-err
branch
from
f1a0bc3
to
b6c8154
Compare
ywk253100
approved these changes
Dec 20, 2021
jenting
approved these changes
Dec 20, 2021
danfengliu
pushed a commit
to danfengliu/velero
that referenced
this pull request
Jan 25, 2022
…ler (vmware-tanzu#4465) Per discussion in vmware-tanzu#4260 (comment) vmware-tanzu#4260 (comment) return the error to avoid a panic when downloading the backup tarball Signed-off-by: Daniel Jiang <jiangd@vmware.com>
2 tasks
gyaozhou
pushed a commit
to gyaozhou/velero-read
that referenced
this pull request
May 14, 2022
…ler (vmware-tanzu#4465) Per discussion in vmware-tanzu#4260 (comment) vmware-tanzu#4260 (comment) return the error to avoid a panic when downloading the backup tarball Signed-off-by: Daniel Jiang <jiangd@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in
#4260 (comment)
#4260 (comment)
return the error to avoid a panic when downloading the backup tarball
Signed-off-by: Daniel Jiang jiangd@vmware.com
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.