Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RestoreItemActions for namespaces #4478

Open
mouellet opened this issue Jan 3, 2022 · 3 comments · May be fixed by #7409
Open

Support RestoreItemActions for namespaces #4478

mouellet opened this issue Jan 3, 2022 · 3 comments · May be fixed by #7409
Assignees

Comments

@mouellet
Copy link

mouellet commented Jan 3, 2022

Describe the problem/challenge you have

We're using Rancher to provision our clusters and it adds annotations on namespaces for their project (the ID and other stuff). A newly provisioned cluster w/ the same projects won't have the same annotation values on namespaces as they are randomly generated. So when we create a new cluster and restore a backup, the restored namespaces aren't in the right project, breaking stuff..

I was looking into making a backup/restore plugin to lookup Rancher's API and update the annotation on namespaces with the new value, but found out that namespaces are not restored as other resources. They don't go through the restore plugin chain, but are just restored from backup.

So I looked into making a multi-step restore process: restore namespaces first, run script to update the annotations then restore everything else, but found that you can't restore only namespaces (see #1970).

Describe the solution you'd like
Let namespaces go through the restore plugin chain on restore instead of directly from backup.

Anything else you would like to add:

Environment:

  • Velero version (use velero version):
  • Kubernetes version (use kubectl version):
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "The project would be better with this feature added"
  • 👎 for "This feature will not enhance the project in a meaningful way"
@reasonerjt
Copy link
Contributor

After reviewing #1970 I think this is a valid requirement

Let namespaces go through the restore plugin chain on restore instead of directly from backup.

I'll discuss with other maintainers, and follow up your PR.

@mouellet
Copy link
Author

Hi @reasonerjt,

Do you think this can be included in a future release? I could join a community meeting if needed...

Also, would you mind reopening my PR? It got closed du to being stale.

Thanks,

@milapointe
Copy link

Hi @reasonerjt,

Do you think this can be included in a future release? I could join a community meeting if needed...

Also, would you mind reopening my PR? It got closed du to being stale.

Thanks,

@reasonerjt : could you reopen the PR ? Also, is there a timeframe to release this since the PR is already completed?

Thanks

@mouellet mouellet linked a pull request Feb 8, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants