Fix: skip not mounted volumes when backing up #4497
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkeven
force-pushed
the
filterunmountedvol
branch
from
ab15b7b
to
854b144
Compare
dkeven
force-pushed
the
filterunmountedvol
branch
from
854b144
to
a77d37b
Compare
reasonerjt
reviewed
Jan 18, 2022
Signed-off-by: dkeven <keven@kubesphere.io>
dkeven
force-pushed
the
filterunmountedvol
branch
from
a77d37b
to
1e44edc
Compare
Signed-off-by: Ming <mqiu@vmware.com>
… and restore (vmware-tanzu#4083) * vmware-tanzu#4067 Initial design of the new plugins - pre-post backup and restore Signed-off-by: Rafael Brito <rbrito@vmware.com> * Update new-prepost-backuprestore-plugin-hooks.md * Updated design doc as per feedback Signed-off-by: Rafael Brito <rbrito@vmware.com> * Adding design changes as per feedback * Update design on prepost-backup-restore plugins * More color on how to call plugins Signed-off-by: Rafael Brito <rbrito@vmware.com> * Proposing annotations to skip plugin execution Signed-off-by: Rafael Brito <rbrito@vmware.com>
Add E2E test of backups sync from BSL
Signed-off-by: danfengl <danfengl@vmware.com>
|
LGTM |
qiuming-best
approved these changes
Jan 21, 2022
…ball-in-pr-ci Upload debug tarball in PR CI E2E pipeline
Fix: skip not mounted volumes when backing up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dkeven keven@kubesphere.io
Thank you for contributing to Velero!
Please add a summary of your change
As mentioned in #4495, unused volumes should be skipped when creating
PodVolumeBackups, just like how the kubelet's volume manager handles it.This PR adds this skipping logic.
Since restic backup for block mode volumes is not supported now (#2780), and should fail to avoid ambiguous behavior, this PR only checks volume against
volumeMountsinstead ofvolumeDevices. (Or should the unused devices be included too?)I've built an image and tested in my own environment.
Does your change fix a particular issue?
Fixes #4495
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.