Check whether the volume is provisioned by CSI driver or not by the annotation as well #4513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywk253100
force-pushed
the
220111_restic
branch
2 times, most recently
from
9fa2c54
to
0eda7a3
Compare
blackpiglet
reviewed
Jan 11, 2022
| @@ -103,7 +103,7 @@ local_resource( | |||
|
|
|||
| local_resource( | |||
| "restic_binary", | |||
| cmd = 'cd ' + '.' + ';mkdir -p _tiltbuild/restic; BIN=velero GOOS=' + local_goos + ' GOARCH=amd64 RESTIC_VERSION=0.12.0 OUTPUT_DIR=_tiltbuild/restic ./hack/download-restic.sh', | |||
| cmd = 'cd ' + '.' + ';mkdir -p _tiltbuild/restic; BIN=velero GOOS=linux GOARCH=amd64 RESTIC_VERSION=0.12.0 OUTPUT_DIR=_tiltbuild/restic ./hack/download-restic.sh', | |||
There was a problem hiding this comment.
Is there any difference after modifying the GOOS setting for the Tiltfile?
reasonerjt
reviewed
Jan 11, 2022
pkg/util/kube/utils.go
Outdated
| // Although the pv.Spec.CSI is nil, the volume could be provisioned by a CSI driver when enabling the CSI migration | ||
| // Refer to https://github.com/vmware-tanzu/velero/issues/4496 for more details | ||
| if pv.Annotations != nil { | ||
| if strings.Contains(pv.Annotations[KubeAnnDynamicallyProvisioned], "csi") { |
There was a problem hiding this comment.
for safety how about checking .csi.?
Can we add a log saying because the provisioned-by annotation is xxxx so I think this is provisioned by CSI?
There was a problem hiding this comment.
There are some drivers named csi.xxx and csi-xxx: https://kubernetes-csi.github.io/docs/drivers.html
ywk253100
force-pushed
the
220111_restic
branch
2 times, most recently
from
7a7d884
to
634bb0e
Compare
…nnotation as well Check whether the volume is provisioned by CSI driver or not by the annotation as well Fixes vmware-tanzu#4496 Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
ywk253100
force-pushed
the
220111_restic
branch
from
634bb0e
to
fcad46c
Compare
reasonerjt
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check whether the volume is provisioned by CSI driver or not by the annotation as well
Fixes #4496
Signed-off-by: Wenkai Yin(尹文开) yinw@vmware.com
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.