restic backupper: ignore volumes of non-running pods #4584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for fervent-minsky-ed95cc canceled. 🔨 Explore the source changes: 36e6d95 🔍 Inspect the deploy log: https://app.netlify.com/sites/fervent-minsky-ed95cc/deploys/61f1f79e98318e0007d99b31 |
euven
force-pushed
the
restic-backups-skip-non-running-pods
branch
from
7ee2089
to
085cfd5
Compare
Signed-off-by: Eugene Venter <eugene@catalyst.net.nz>
Signed-off-by: Eugene Venter <eugene@catalyst.net.nz>
euven
force-pushed
the
restic-backups-skip-non-running-pods
branch
from
085cfd5
to
36e6d95
Compare
sseago
approved these changes
Feb 2, 2022
jenting
approved these changes
Feb 10, 2022
|
This fixes the issue we've encountered, where Velero reports "PartiallyFailed" for otherwise successful backups when there are completed jobs included. |
gyaozhou
pushed a commit
to gyaozhou/velero-read
that referenced
this pull request
May 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch deals with cases like completed jobs failing to back up, by ignoring backup attempts for volumes of pods that are no longer running.
Fixes #2395
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.