E2E SSR test add retry mechanism and logs #4591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for fervent-minsky-ed95cc canceled. 🔨 Explore the source changes: e404601 🔍 Inspect the deploy log: https://app.netlify.com/sites/fervent-minsky-ed95cc/deploys/61f3caccd6703e0007fd886b |
qiuming-best
requested review from
reasonerjt and
danfengliu
and removed request for
zubron and
blackpiglet
danfengliu
previously approved these changes
Jan 28, 2022
qiuming-best
force-pushed
the
ssr
branch
4 times, most recently
from
60f7097
to
09ca005
Compare
reasonerjt
reviewed
Jan 28, 2022
Signed-off-by: Ming <mqiu@vmware.com>
reasonerjt
approved these changes
Jan 28, 2022
danfengliu
reviewed
Jan 29, 2022
| if err == waitutil.ErrWaitTimeout { | ||
| fmt.Printf("exceed test case deadline and failed to check ssr object in %s namespace", VeleroCfg.VeleroNamespace) | ||
| } | ||
| Expect(err).To(Succeed(), fmt.Sprintf("Failed to check ssr object in %s namespace", VeleroCfg.VeleroNamespace)) | ||
|
|
||
| By(fmt.Sprintf("Check ssr object in %s namespace", testNS)) |
There was a problem hiding this comment.
Why repeated code with line #76?
There was a problem hiding this comment.
It tested in two different namespaces, one is the velero installation namespace, another is not a velero installation namespace. velero installation namespace should get server version, another should not get the server version
danfengliu
approved these changes
Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ming mqiu@vmware.com
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
it reference to #4590
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.