Convert Pod Volume Restore resource/controller to the Kubebuilder framework #4655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywk253100
force-pushed
the
220214_pod_volume_restore
branch
from
55af3a9
to
f6fcfdf
Compare
blackpiglet
reviewed
Feb 21, 2022
blackpiglet
reviewed
Feb 21, 2022
blackpiglet
reviewed
Feb 21, 2022
blackpiglet
reviewed
Feb 21, 2022
ywk253100
force-pushed
the
220214_pod_volume_restore
branch
4 times, most recently
from
9599b66
to
aabf9a9
Compare
blackpiglet
previously approved these changes
Mar 8, 2022
ywk253100
force-pushed
the
220214_pod_volume_restore
branch
2 times, most recently
from
80ab6da
to
12e3081
Compare
ywk253100
changed the title
…mework Convert Pod Volume Restore resource/controller to the Kubebuilder framework Fixes vmware-tanzu#4134 Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
ywk253100
force-pushed
the
220214_pod_volume_restore
branch
from
12e3081
to
c2c211f
Compare
ywk253100
changed the title
ywk253100
commented
Apr 27, 2022
| jsonPath: .spec.pod.namespace | ||
| name: Namespace | ||
| type: string | ||
| - description: Name of the pod containing the volume to be restored |
There was a problem hiding this comment.
It's the name of the pod not the name of PVR, and it shows as column Pod when running kubectl
reasonerjt
reviewed
Apr 27, 2022
blackpiglet
approved these changes
Apr 28, 2022
reasonerjt
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert Pod Volume Restore resource/controller to the Kubebuilder framework
Fixes #4134
Signed-off-by: Wenkai Yin(尹文开) yinw@vmware.com
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.