[fix] Add regional PV support for GKE #4680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix vmware-tanzu#4663. For GKE pv, when create backup, return all zones retrived from node affinity. Signed-off-by: Xun Jiang <jxun@vmware.com>
reasonerjt
reviewed
Feb 22, 2022
pkg/backup/item_backupper_test.go
Outdated
| @@ -131,6 +131,21 @@ func Test_zoneFromPVNodeAffinity(t *testing.T) { | |||
| wantKey: "topology.disk.csi.azure.com/zone", | |||
| wantValue: "us-central", | |||
| }, | |||
| { | |||
| name: "Volume with multiple valid keys, and provider is gke, returns the all match", // it should never happen | |||
There was a problem hiding this comment.
The comment is misleading, instead you should provide the concrete use case when testing the regional disk?
It does not retuan all match, in your tc us-east-2b is dropped.
reasonerjt
reviewed
Feb 22, 2022
pkg/backup/item_backupper.go
Outdated
| @@ -384,6 +385,7 @@ const ( | |||
| awsEbsCsiZoneKey = "topology.ebs.csi.aws.com/zone" | |||
| azureCsiZoneKey = "topology.disk.csi.azure.com/zone" | |||
| gkeCsiZoneKey = "topology.gke.io/zone" | |||
| zoneSeparator = "__" | |||
There was a problem hiding this comment.
is the zone separator for gcp only or all cloud providers?
There was a problem hiding this comment.
GKE only. I will update
1. rename zoneSeparator to gkeZoneSeparator 2. add example of regional PV's node affinity. modify test case description. Signed-off-by: Xun Jiang <jxun@vmware.com>
blackpiglet
force-pushed
the
4663-add-regional-disk-support
branch
from
782982f
to
4c8d1c2
Compare
reasonerjt
approved these changes
Feb 22, 2022
ywk253100
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4663.
For GKE pv, when create backup, return all zones retrived from node affinity.
Signed-off-by: Xun Jiang jxun@vmware.com
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.