Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip povdolumerestore creation when restore excludes pv/pvc #4769

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Skip povdolumerestore creation when restore excludes pv/pvc #4769

merged 1 commit into from
Apr 19, 2022

Conversation

half-life666
Copy link
Contributor

@half-life666 half-life666 commented Mar 23, 2022

Signed-off-by: half-life666 half-life@jibudata.com

Thank you for contributing to Velero!

Please add a summary of your change

Do podvolumerestore only when restore includes pv/pvc

Does your change fix a particular issue?

Fixes # issue 4754

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@codecov-commenter
Copy link

Codecov Report

Merging #4769 (03e875f) into main (38c83d6) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4769      +/-   ##
==========================================
+ Coverage   40.84%   40.87%   +0.03%     
==========================================
  Files         202      202              
  Lines       18007    18032      +25     
==========================================
+ Hits         7355     7371      +16     
- Misses      10127    10135       +8     
- Partials      525      526       +1     
Impacted Files Coverage Δ
pkg/restore/restore.go 66.69% <100.00%> (+0.05%) ⬆️
pkg/controller/gc_controller.go 78.18% <0.00%> (-2.67%) ⬇️
pkg/controller/backup_controller.go 60.00% <0.00%> (-0.57%) ⬇️
internal/hook/item_hook_handler.go 89.40% <0.00%> (+0.21%) ⬆️
pkg/restore/init_restorehook_pod_action.go 54.54% <0.00%> (+2.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38c83d6...03e875f. Read the comment docs.

@jenting
Copy link
Contributor

jenting commented Mar 31, 2022

Could you update the last commit with sign off by (DCO)? Thank you.

Signed-off-by: half-life666 <half-life@jibudata.com>
@half-life666
Copy link
Contributor Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants