Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the restore hook applied to new namespace based on the mapping #4779

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

reasonerjt
Copy link
Contributor

fixes #4720

Signed-off-by: Daniel Jiang jiangd@vmware.com

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

fixes vmware-tanzu#4720

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2022

Codecov Report

Merging #4779 (2939914) into main (d1fdaec) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #4779   +/-   ##
=======================================
  Coverage   40.86%   40.87%           
=======================================
  Files         202      202           
  Lines       18023    18030    +7     
=======================================
+ Hits         7365     7369    +4     
- Misses      10133    10135    +2     
- Partials      525      526    +1     
Impacted Files Coverage Δ
internal/hook/item_hook_handler.go 89.40% <100.00%> (+0.21%) ⬆️
pkg/restore/init_restorehook_pod_action.go 54.54% <100.00%> (+2.16%) ⬆️
pkg/controller/backup_controller.go 60.00% <0.00%> (-0.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1fdaec...2939914. Read the comment docs.

@ywk253100 ywk253100 merged commit 0b8f19e into vmware-tanzu:main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hooks on restore with namespace mapping not applied depending on namespace label and hook type (exec/init)
4 participants