Make the vsc created by backup sync controller deletable #4832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reasonerjt
force-pushed
the
fix-rm-csi-bak-tmp
branch
2 times, most recently
from
8386835
to
f429186
Compare
reasonerjt
pushed a commit
to reasonerjt/velero-plugin-for-csi
that referenced
this pull request
Apr 18, 2022
This commit makes sure the behavior of the plugin is consistent with velero, it reset the fields in VSC before it's persisted, to avoid causing unexpected behavior in CSI snapshotter when the VSC is restored. More details please see the description in vmware-tanzu/velero#4832 Signed-off-by: Daniel Jiang <jiangd@vmware.com>
blackpiglet
reviewed
Apr 18, 2022
Fixes vmware-tanzu#4760 This commit make changes in 2 parts: 1) When a volumesnapshotcontent is persisted during backup, velero will reset its `Source` field to remove the VolumeHandle, so that the csi-snapshotter will not try to call `CreateSnapshot` when its synced to another cluster with a backup. 2) Make sure the referenced volumesnapshotclasses are persisted and synced with the backup, so that when the volumesnapshotcontent is deleted the storage snapshot is also removed. Signed-off-by: Daniel Jiang <jiangd@vmware.com>
reasonerjt
force-pushed
the
fix-rm-csi-bak-tmp
branch
from
7196dce
to
4f9e445
Compare
Codecov Report
@@ Coverage Diff @@
## main #4832 +/- ##
==========================================
+ Coverage 40.92% 41.36% +0.43%
==========================================
Files 203 204 +1
Lines 17995 18059 +64
==========================================
+ Hits 7365 7470 +105
+ Misses 10104 10042 -62
- Partials 526 547 +21
Continue to review full report at Codecov.
|
blackpiglet
approved these changes
Apr 19, 2022
ywk253100
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4760
This commit make changes in 2 parts:
Sourcefield to remove the VolumeHandle, so that thecsi-snapshotter will not try to call
CreateSnapshotwhen its syncedto another cluster with a backup.
synced with the backup, so that when the volumesnapshotcontent is
deleted the storage snapshot is also removed.
Signed-off-by: Daniel Jiang jiangd@vmware.com
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.