Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use controller-gen to generate the deep copy methods for objects #4838

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

ywk253100
Copy link
Contributor

As we are refactoring controllers with kubebuilder, use the controller-gen rather than code-generator to generate the deep copy methods for objects

Signed-off-by: Wenkai Yin(尹文开) yinw@vmware.com

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@ywk253100 ywk253100 added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Apr 18, 2022
As we are refactoring controllers with kubebuilder, use the controller-gen rather than code-generator to generate the deep copy methods for objects

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
@codecov-commenter
Copy link

Codecov Report

Merging #4838 (28bc8b7) into main (65db258) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4838   +/-   ##
=======================================
  Coverage   41.41%   41.41%           
=======================================
  Files         204      204           
  Lines       17948    17948           
=======================================
  Hits         7434     7434           
  Misses       9970     9970           
  Partials      544      544           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65db258...28bc8b7. Read the comment docs.

@reasonerjt reasonerjt merged commit 3ec96e2 into vmware-tanzu:main Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-changelog kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants