Refactor backup deletion controller based on kubebuilder #4855

reasonerjt · 2022-04-25T10:05:10Z

Signed-off-by: Daniel Jiang jiangd@vmware.com

Thank you for contributing to Velero!

Fixes #(issue)

Please indicate you've done the following:

Accepted the DCO. Commits without the DCO will delay acceptance.
Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
Updated the corresponding documentation in site/content/docs/main.

pkg/controller/backup_deletion_controller.go

Signed-off-by: Daniel Jiang <jiangd@vmware.com>

pkg/controller/backup_deletion_controller_test.go

reasonerjt requested review from ywk253100 and blackpiglet April 25, 2022 10:05

github-actions bot requested a review from qiuming-best April 25, 2022 10:05

github-actions bot assigned reasonerjt Apr 25, 2022

github-actions bot added the has-unit-tests label Apr 25, 2022

reasonerjt force-pushed the bak-delete-refact branch from 9d4a811 to effec96 Compare April 25, 2022 10:06

github-actions bot added the has-changelog label Apr 25, 2022

reasonerjt force-pushed the bak-delete-refact branch from effec96 to 43c40d8 Compare April 25, 2022 10:37

shawn-hurley reviewed Apr 25, 2022

View reviewed changes

pkg/controller/backup_deletion_controller.go Outdated Show resolved Hide resolved

blackpiglet reviewed Apr 26, 2022

View reviewed changes

pkg/controller/backup_deletion_controller.go Show resolved Hide resolved

blackpiglet reviewed Apr 26, 2022

View reviewed changes

pkg/controller/backup_deletion_controller.go Show resolved Hide resolved

reasonerjt force-pushed the bak-delete-refact branch 2 times, most recently from b9ef9f3 to 466d6d8 Compare April 27, 2022 06:15

ywk253100 reviewed Apr 27, 2022

View reviewed changes

pkg/controller/backup_deletion_controller.go Outdated Show resolved Hide resolved

Refactor backup deletion controller based on kubebuilder

74fd158

Signed-off-by: Daniel Jiang <jiangd@vmware.com>

reasonerjt force-pushed the bak-delete-refact branch from 466d6d8 to 74fd158 Compare April 27, 2022 09:01

ywk253100 approved these changes Apr 28, 2022

View reviewed changes

blackpiglet reviewed Apr 28, 2022

View reviewed changes

pkg/controller/backup_deletion_controller_test.go Show resolved Hide resolved

blackpiglet approved these changes Apr 28, 2022

View reviewed changes

blackpiglet merged commit 001229a into vmware-tanzu:main Apr 28, 2022

reasonerjt mentioned this pull request May 5, 2022

Convert Delete Backup resource/controller to the Kubebuilder framework #4669

Closed