Remove VolumeSnapshot created during backup #4858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackpiglet
force-pushed
the
4761-remove-volumesnapshot-after-backup
branch
from
e5d2ea9
to
63c66a6
Compare
blackpiglet
requested review from
reasonerjt and
ywk253100
and removed request for
dsu-igeek
|
It doesn't seem correct to me:
|
blackpiglet
changed the title
blackpiglet
force-pushed
the
4761-remove-volumesnapshot-after-backup
branch
from
63c66a6
to
001540b
Compare
reasonerjt
reviewed
May 3, 2022
reasonerjt
reviewed
May 3, 2022
blackpiglet
force-pushed
the
4761-remove-volumesnapshot-after-backup
branch
6 times, most recently
from
7688b9c
to
f841d2b
Compare
reasonerjt
reviewed
May 5, 2022
ywk253100
reviewed
May 5, 2022
ywk253100
reviewed
May 5, 2022
ywk253100
reviewed
May 5, 2022
blackpiglet
force-pushed
the
4761-remove-volumesnapshot-after-backup
branch
from
f841d2b
to
cd9a43d
Compare
…lass's DeletionPolicy is set to Delete. 1. Delete VolumeSnapshot directly when DeletionPolicy set to Retain. 2. Change VolumeSnapshotContent's DeletionPolicy to Retain, then delete VolumeSnapshot. After that delete VolumeSnapshotContent and change VSC DeletionPolicy to Delete back, then re-create the VolumeSnapshotContent. Signed-off-by: Xun Jiang <jxun@vmware.com>
blackpiglet
force-pushed
the
4761-remove-volumesnapshot-after-backup
branch
from
cd9a43d
to
a69bd8b
Compare
ywk253100
approved these changes
May 6, 2022
reasonerjt
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xun Jiang jxun@vmware.com
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #4761
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.