Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split pkg/restic package #5143

Merged
merged 1 commit into from Aug 5, 2022
Merged

Conversation

ywk253100
Copy link
Contributor

This commit splits the pkg/restic package into several packages to support Kopia integration works

Fixes #5055

Signed-off-by: Wenkai Yin(尹文开) yinw@vmware.com

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@ywk253100 ywk253100 marked this pull request as draft July 22, 2022 02:36
@ywk253100 ywk253100 force-pushed the 220721_pkg branch 2 times, most recently from 75c3b5f to 397776f Compare July 22, 2022 03:26
@github-actions github-actions bot added the Dependencies Pull requests that update a dependency file label Jul 22, 2022
@github-actions github-actions bot removed the Dependencies Pull requests that update a dependency file label Jul 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2022

Codecov Report

Merging #5143 (a090212) into main (52fd18e) will increase coverage by 0.32%.
The diff coverage is 35.89%.

@@            Coverage Diff             @@
##             main    #5143      +/-   ##
==========================================
+ Coverage   41.20%   41.52%   +0.32%     
==========================================
  Files         212      213       +1     
  Lines       18666    18541     -125     
==========================================
+ Hits         7692     7700       +8     
+ Misses      10399    10267     -132     
+ Partials      575      574       -1     
Impacted Files Coverage Δ
pkg/backup/item_backupper.go 78.22% <ø> (ø)
pkg/controller/restic_repository_controller.go 54.36% <ø> (ø)
pkg/repository/config/config.go 95.91% <ø> (ø)
pkg/restic/common.go 55.90% <ø> (-9.95%) ⬇️
pkg/restic/repository_manager.go 9.84% <0.00%> (+1.72%) ⬆️
pkg/uploader/backupper.go 4.97% <0.00%> (ø)
pkg/uploader/backupper_factory.go 0.00% <0.00%> (ø)
pkg/uploader/restorer.go 0.00% <0.00%> (ø)
pkg/uploader/restorer_factory.go 0.00% <0.00%> (ø)
pkg/restore/restore.go 64.63% <75.00%> (+0.56%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52fd18e...a090212. Read the comment docs.

@blackpiglet blackpiglet changed the title Splic pkg/restic package Split pkg/restic package Jul 23, 2022
@ywk253100 ywk253100 marked this pull request as ready for review July 29, 2022 09:29
@ywk253100 ywk253100 requested review from Lyndon-Li and reasonerjt and removed request for shubham-pampattiwar and blackpiglet July 29, 2022 09:29
pkg/restic/common.go Outdated Show resolved Hide resolved
pkg/restic/mocks/repository_manager.go Outdated Show resolved Hide resolved
pkg/uploader/util.go Outdated Show resolved Hide resolved
Lyndon-Li
Lyndon-Li previously approved these changes Aug 2, 2022
Lyndon-Li
Lyndon-Li previously approved these changes Aug 5, 2022
@reasonerjt
Copy link
Contributor

reasonerjt commented Aug 5, 2022

Sorry for the delayed response, but how about we rename pkg/uploader to pkg/podvolume ?

cc @Lyndon-Li

This commit splits the pkg/restic package into several packages to support Kopia integration works

Fixes vmware-tanzu#5055

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
Copy link
Contributor

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ywk253100 ywk253100 merged commit 092fc01 into vmware-tanzu:main Aug 5, 2022
danfengliu pushed a commit to danfengliu/velero that referenced this pull request Sep 13, 2022
This commit splits the pkg/restic package into several packages to support Kopia integration works

Fixes vmware-tanzu#5055

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split the restic package
4 participants