Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay CA file deletion in PVB controller #5145

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Jul 22, 2022

Fix #5140.

Need to consider whether this PR is needed in v1.9.1

Signed-off-by: Xun Jiang jxun@vmware.com

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@blackpiglet blackpiglet self-assigned this Jul 22, 2022
@blackpiglet blackpiglet force-pushed the 5140-fix-restic-backup-with-customize-CA branch from 21f50ce to e9c3666 Compare July 22, 2022 11:35
Fix vmware-tanzu#5140.

Signed-off-by: Xun Jiang <jxun@vmware.com>
@blackpiglet blackpiglet force-pushed the 5140-fix-restic-backup-with-customize-CA branch from e9c3666 to 82ac228 Compare July 22, 2022 11:36
Copy link
Contributor

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qiuming-best qiuming-best merged commit f68ae92 into vmware-tanzu:main Jul 26, 2022
@blackpiglet blackpiglet deleted the 5140-fix-restic-backup-with-customize-CA branch October 15, 2022 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Velero 1.9.0 breaks restic with custom CA
3 participants