Skip registering "crd-remap-version" plugin when feature flag "EnableAPIGroupVersions" is set #5165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reasonerjt
requested review from
ywk253100 and
blackpiglet
and removed request for
dsu-igeek and
qiuming-best
reasonerjt
changed the title
"EnableAPIGroupVersions" is set The crd-remap-version plugin will always backup v1b1 resource for some CRD. It impacts the feature flag `EnableAPIGroupVersions` which means to backup all versions, and make migration fail. In this commit the featureSet was removed from plugin server struct b/c it blocks the parm `--features` to be populated correctly. This change should not have negative impact b/c the attribute in server struct is never used. Fixes vmware-tanzu#5146 Signed-off-by: Daniel Jiang <jiangd@vmware.com>
blackpiglet
approved these changes
Aug 1, 2022
ywk253100
approved these changes
Aug 2, 2022
reasonerjt
added a commit
to reasonerjt/velero
that referenced
this pull request
Aug 2, 2022
…-tanzu#5165) "EnableAPIGroupVersions" is set The crd-remap-version plugin will always backup v1b1 resource for some CRD. It impacts the feature flag `EnableAPIGroupVersions` which means to backup all versions, and make migration fail. In this commit the featureSet was removed from plugin server struct b/c it blocks the parm `--features` to be populated correctly. This change should not have negative impact b/c the attribute in server struct is never used. Fixes vmware-tanzu#5146 Signed-off-by: Daniel Jiang <jiangd@vmware.com>
reasonerjt
added a commit
to reasonerjt/velero
that referenced
this pull request
Aug 2, 2022
…-tanzu#5165) "EnableAPIGroupVersions" is set The crd-remap-version plugin will always backup v1b1 resource for some CRD. It impacts the feature flag `EnableAPIGroupVersions` which means to backup all versions, and make migration fail. In this commit the featureSet was removed from plugin server struct b/c it blocks the parm `--features` to be populated correctly. This change should not have negative impact b/c the attribute in server struct is never used. Fixes vmware-tanzu#5146 Signed-off-by: Daniel Jiang <jiangd@vmware.com>
ywk253100
pushed a commit
that referenced
this pull request
Aug 3, 2022
…#5173) "EnableAPIGroupVersions" is set The crd-remap-version plugin will always backup v1b1 resource for some CRD. It impacts the feature flag `EnableAPIGroupVersions` which means to backup all versions, and make migration fail. In this commit the featureSet was removed from plugin server struct b/c it blocks the parm `--features` to be populated correctly. This change should not have negative impact b/c the attribute in server struct is never used. Fixes #5146 Signed-off-by: Daniel Jiang <jiangd@vmware.com>
danfengliu
pushed a commit
to danfengliu/velero
that referenced
this pull request
Sep 13, 2022
…-tanzu#5165) "EnableAPIGroupVersions" is set The crd-remap-version plugin will always backup v1b1 resource for some CRD. It impacts the feature flag `EnableAPIGroupVersions` which means to backup all versions, and make migration fail. In this commit the featureSet was removed from plugin server struct b/c it blocks the parm `--features` to be populated correctly. This change should not have negative impact b/c the attribute in server struct is never used. Fixes vmware-tanzu#5146 Signed-off-by: Daniel Jiang <jiangd@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"EnableAPIGroupVersions" is set
The crd-remap-version plugin will always backup v1b1 resource for some
CRD. It impacts the feature flag
EnableAPIGroupVersionswhich means tobackup all versions, and make migration fail.
In this commit the featureSet was removed from plugin server struct b/c
it blocks the parm
--featuresto be populated correctly. This changeshould not have negative impact b/c the attribute in server struct is never used.
Fixes #5146
Signed-off-by: Daniel Jiang jiangd@vmware.com
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.