Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restore cmd extraflag overwrite bug #5347

Merged
merged 1 commit into from Sep 15, 2022

Conversation

qiuming-best
Copy link
Contributor

@qiuming-best qiuming-best commented Sep 15, 2022

Signed-off-by: Ming mqiu@vmware.com

Thank you for contributing to Velero!

Please add a summary of your change

Fix restore from backup will override extraflag bug
Change RunBackup and RunRestore debug log into Info level log for error tracking
Check credentialsFile and caCertFile file whether are exist before remove

Does your change fix a particular issue?

Fixes #(issue)
#5346

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Signed-off-by: Ming <mqiu@vmware.com>
@qiuming-best qiuming-best changed the title Fix restore cmd extraflag overwirte bug Fix restore cmd extraflag overwrite bug Sep 15, 2022
@qiuming-best qiuming-best requested review from Lyndon-Li, blackpiglet and reasonerjt and removed request for dsu-igeek September 15, 2022 06:11
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2022

Codecov Report

Merging #5347 (4022020) into main (8888f87) will increase coverage by 0.20%.
The diff coverage is 12.50%.

@@            Coverage Diff             @@
##             main    #5347      +/-   ##
==========================================
+ Coverage   40.62%   40.82%   +0.20%     
==========================================
  Files         233      234       +1     
  Lines       20271    20267       -4     
==========================================
+ Hits         8235     8274      +39     
+ Misses      11437    11391      -46     
- Partials      599      602       +3     
Impacted Files Coverage Δ
pkg/uploader/provider/restic.go 26.59% <12.50%> (-4.44%) ⬇️
pkg/restore/pv_restorer.go 65.21% <0.00%> (-2.48%) ⬇️
pkg/podvolume/backupper.go 4.66% <0.00%> (-0.15%) ⬇️
pkg/controller/backup_controller.go 48.06% <0.00%> (-0.13%) ⬇️
pkg/cmd/server/server.go 6.59% <0.00%> (-0.04%) ⬇️
pkg/repository/ensurer.go 0.00% <0.00%> (ø)
pkg/podvolume/backupper_factory.go 0.00% <0.00%> (ø)
pkg/builder/volume_snapshot_location_builder.go 0.00% <0.00%> (ø)
pkg/util/kube/pod.go 0.00% <0.00%> (ø)
pkg/restore/restore.go 64.85% <0.00%> (+0.39%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@blackpiglet blackpiglet merged commit 745ebbe into vmware-tanzu:main Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants