Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify help message of parameter --snapshot-volumes #5350

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Sep 16, 2022

Clarify the help message for the default value of parameter --snapshot-volumes, when it's not set.

Signed-off-by: Xun Jiang blackpiglet@gmail.com

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #5019

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@blackpiglet blackpiglet self-assigned this Sep 16, 2022
…t-volumes, when it's not set.

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
@blackpiglet blackpiglet force-pushed the 5019-snapshot-volumes-help-message-modification branch from 56d032d to d134783 Compare September 16, 2022 08:03
@blackpiglet blackpiglet requested review from qiuming-best and removed request for dsu-igeek September 16, 2022 08:03
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2022

Codecov Report

Merging #5350 (56d032d) into main (4768c2a) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 56d032d differs from pull request most recent head d134783. Consider uploading reports for the commit d134783 to get more accurate results

@@           Coverage Diff           @@
##             main    #5350   +/-   ##
=======================================
  Coverage   40.81%   40.81%           
=======================================
  Files         234      234           
  Lines       20275    20275           
=======================================
  Hits         8276     8276           
  Misses      11396    11396           
  Partials      603      603           
Impacted Files Coverage Δ
pkg/cmd/cli/backup/create.go 22.32% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@danfengliu danfengliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qiuming-best qiuming-best merged commit 648311a into vmware-tanzu:main Sep 20, 2022
@blackpiglet blackpiglet deleted the 5019-snapshot-volumes-help-message-modification branch October 15, 2022 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusion of option --snapshot-volumes in Velero create backup CLI
4 participants