Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Test_prepareBackupRequest_BackupStorageLocation UT failure. #5394

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Sep 26, 2022

Signed-off-by: Xun Jiang blackpiglet@gmail.com

Thank you for contributing to Velero!

Please add a summary of your change

Fix UT case Test_prepareBackupRequest_BackupStorageLocation introduced by #5362 failure.
function prepareBackupRequest add an additional logger parameter in #5370 .

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
@blackpiglet blackpiglet force-pushed the fix_prepareBackupRequest_UT_failure branch from f81778c to 9693aca Compare September 26, 2022 09:10
@blackpiglet blackpiglet requested review from Lyndon-Li and removed request for dsu-igeek September 26, 2022 09:12
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2022

Codecov Report

Merging #5394 (9693aca) into main (66f6365) will increase coverage by 0.02%.
The diff coverage is 84.21%.

@@            Coverage Diff             @@
##             main    #5394      +/-   ##
==========================================
+ Coverage   40.56%   40.59%   +0.02%     
==========================================
  Files         236      236              
  Lines       20385    20399      +14     
==========================================
+ Hits         8269     8280      +11     
- Misses      11511    11513       +2     
- Partials      605      606       +1     
Impacted Files Coverage Δ
pkg/repository/provider/unified_repo.go 57.83% <76.92%> (+0.77%) ⬆️
pkg/repository/udmrepo/kopialib/backend/utils.go 70.73% <100.00%> (+0.73%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@qiuming-best qiuming-best merged commit 3b3260c into vmware-tanzu:main Sep 27, 2022
@blackpiglet blackpiglet deleted the fix_prepareBackupRequest_UT_failure branch October 15, 2022 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants