update k8s.io dependencies to 0.24.0 #5471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This also required an update to use github.com/bombsimon/logrusr/v3 * 'WithClusterName' removed as per the k8s doc reasoning: * https://github.com/kubernetes/apimachinery/blob/release-1.24/pkg/apis/meta/v1/types.go\#L257-L259 * ('ClusterName was a legacy field that was always cleared by the system and never used') * Test was updated accordingly Signed-off-by: Kira Boyle <kira@replicated.com>
github-actions
bot
added
Dependencies
Codecov Report
@@ Coverage Diff @@
## main #5471 +/- ##
=======================================
Coverage 40.56% 40.57%
=======================================
Files 236 236
Lines 20484 20480 -4
=======================================
Hits 8310 8310
+ Misses 11565 11561 -4
Partials 609 609
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
| Removed the `WithClusterName` method | ||
| as it is a "legacy field that was | ||
| always cleared by the system and never used" as per upstream k8s | ||
| https://github.com/kubernetes/apimachinery/blob/release-1.24/pkg/apis/meta/v1/types.go#L257-L259 |
There was a problem hiding this comment.
Does it ok with multiple lines of changelogs? @ywk253100
qiuming-best
approved these changes
Oct 24, 2022
blackpiglet
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.