Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue fix 5477 #5478

Merged
merged 1 commit into from Nov 1, 2022
Merged

Conversation

Lyndon-Li
Copy link
Contributor

@Lyndon-Li Lyndon-Li commented Oct 24, 2022

Issue fix 5477: create the common way to support S3 compatible object storages that work for both Restic and Kopia; Keep the resticRepoPrefix parameter for compatibility

fix issue #5477

@Lyndon-Li
Copy link
Contributor Author

Lyndon-Li commented Oct 24, 2022

@sseago @shubham-pampattiwar

Please help to review this PR. This involves a behavior change - technically we want to remove the resticRepoPrefix parameter in BSL's spec.Config map because it works for Restic only, so this PR makes a slight code change to make the second way(specify endpoint, bucket, etc. separately) work; meanwhile, we just keep it there for compatibility.

Check the issue description for details.

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
@codecov-commenter
Copy link

Codecov Report

Merging #5478 (9695340) into main (11a7c79) will increase coverage by 0.15%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##             main    #5478      +/-   ##
==========================================
+ Coverage   40.56%   40.72%   +0.15%     
==========================================
  Files         236      238       +2     
  Lines       20484    20568      +84     
==========================================
+ Hits         8310     8376      +66     
- Misses      11565    11576      +11     
- Partials      609      616       +7     
Impacted Files Coverage Δ
pkg/restic/common.go 26.86% <0.00%> (ø)
pkg/repository/config/config.go 100.00% <100.00%> (+4.08%) ⬆️
pkg/repository/provider/unified_repo.go 57.83% <100.00%> (ø)
pkg/restore/restore.go 64.16% <0.00%> (-0.57%) ⬇️
pkg/builder/object_meta.go 0.00% <0.00%> (ø)
pkg/builder/volume_snapshot_builder.go 0.00% <0.00%> (ø)
pkg/builder/volume_snapshot_content_builder.go 0.00% <0.00%> (ø)
pkg/controller/backup_controller.go 55.23% <0.00%> (+7.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@blackpiglet blackpiglet merged commit ae1e42c into vmware-tanzu:main Nov 1, 2022
@Lyndon-Li Lyndon-Li deleted the s3-compatible-provider branch November 1, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants