Enhance the restore priorities list to support specifying the low prioritized resources that need to be restored in the last #5529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reasonerjt
reviewed
Nov 2, 2022
pkg/restore/restore.go
Outdated
| for resource := range backupResources { | ||
| if _, exist := lowPriorities[resource]; exist { |
There was a problem hiding this comment.
For consistency how about also remove the high priority resources?
pkg/restore/priority.go
Outdated
| // Resources in the HighPriorities list will be handled first | ||
| // Resources in the LowPriorities list will be handled last | ||
| // Other resources will be handled alphabetically after the high prioritized resources and before the low prioritized resources | ||
| type Priority struct { |
There was a problem hiding this comment.
nit: the Priority should be plural? i.e. Priority -> Priorities
pkg/restore/priority.go
Outdated
| } | ||
| // the separator isn't the last element | ||
| if len(strs) > i+1 { | ||
| p.LowPriorities = strs[i+1:] |
There was a problem hiding this comment.
What if there are multiple - in the input?
blackpiglet
previously approved these changes
Nov 2, 2022
blackpiglet
dismissed
their stale review
There still are comments not resolved.
ywk253100
force-pushed
the
221030_restore_order
branch
from
cb01f93
to
3fc9ab3
Compare
…oritized resources that need to be restored in the last Enhance the restore priorities list to support specifying the low prioritized resources that need to be r estored in the last Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
ywk253100
force-pushed
the
221030_restore_order
branch
from
3fc9ab3
to
6750836
Compare
reasonerjt
approved these changes
Nov 2, 2022
blackpiglet
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the restore priorities list to support specifying the low prioritized resources that need to be r estored in the last
Signed-off-by: Wenkai Yin(尹文开) yinw@vmware.com
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.