Add compile restic binary for CVE fix #5564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiuming-best
added
the
kind/changelog-not-required
qiuming-best
force-pushed
the
restic-build
branch
from
e8a7519
to
5dc6244
Compare
qiuming-best
requested review from
Lyndon-Li,
blackpiglet,
ywk253100 and
reasonerjt
Lyndon-Li
previously approved these changes
Nov 8, 2022
reasonerjt
reviewed
Nov 8, 2022
Dockerfile
Outdated
| @@ -29,7 +29,7 @@ WORKDIR /go/src/github.com/vmware-tanzu/velero | |||
|
|
|||
| COPY . /go/src/github.com/vmware-tanzu/velero | |||
|
|
|||
| RUN apt-get update && apt-get install -y bzip2 | |||
| RUN apt-get update && apt-get install -y bzip2 git | |||
There was a problem hiding this comment.
Do you need this? The debian base image has git already as I remember.
And the bzip2 is no longer needed therefore the whole apt-get may be skipped.
There was a problem hiding this comment.
@reasonerjt Done
reasonerjt
reviewed
Nov 8, 2022
hack/build-restic.sh
Outdated
| chmod +x ${restic_bin} | ||
| cd ${build_path}/velero |
There was a problem hiding this comment.
This will break once the directory changes, how about switch to pushd/popd to make it more robust?
There was a problem hiding this comment.
yes, using pushd/popd is much more better
qiuming-best
force-pushed
the
restic-build
branch
from
5dc6244
to
e974cc3
Compare
blackpiglet
previously approved these changes
Nov 9, 2022
|
@qiuming-best |
Codecov Report
@@ Coverage Diff @@
## release-1.9 #5564 +/- ##
============================================
Coverage 41.66% 41.66%
============================================
Files 214 214
Lines 18599 18599
============================================
Hits 7749 7749
Misses 10267 10267
Partials 583 583 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
qiuming-best
force-pushed
the
restic-build
branch
from
a5824fb
to
c76a790
Compare
github-actions
bot
added
Area/Design
Signed-off-by: Ming <mqiu@vmware.com>
qiuming-best
force-pushed
the
restic-build
branch
from
c76a790
to
58f64e6
Compare
github-actions
bot
removed
has-e2e-tests
Area/Design
github-actions
bot
removed
Dependencies
reasonerjt
approved these changes
Nov 9, 2022
blackpiglet
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ming mqiu@vmware.com
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Fix CVE scanned from TMC by compiling
resticbinary using a higher version of golangPlease indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.