Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Item Action v2 API implementation #5569

Merged
merged 1 commit into from Jan 18, 2023

Conversation

sseago
Copy link
Collaborator

@sseago sseago commented Nov 8, 2022

Thank you for contributing to Velero!

Please add a summary of your change

This PR implements the RestoreItemAction v2 API design.

Does your change fix a particular issue?

Fixes #5063

Please indicate you've done the following:

  • [x ] Accepted the DCO. Commits without the DCO will delay acceptance.
  • [ x] Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@codecov-commenter
Copy link

Codecov Report

Merging #5569 (c629079) into main (5c98e88) will decrease coverage by 0.05%.
The diff coverage is 38.36%.

@@            Coverage Diff             @@
##             main    #5569      +/-   ##
==========================================
- Coverage   40.90%   40.84%   -0.06%     
==========================================
  Files         239      244       +5     
  Lines       20624    21129     +505     
==========================================
+ Hits         8437     8631     +194     
- Misses      11570    11874     +304     
- Partials      617      624       +7     
Impacted Files Coverage Δ
pkg/backup/request.go 100.00% <ø> (ø)
pkg/plugin/framework/action_resolver.go 5.00% <0.00%> (-1.90%) ⬇️
...ramework/backupitemaction/v2/backup_item_action.go 0.00% <0.00%> (ø)
...k/backupitemaction/v2/backup_item_action_client.go 0.00% <0.00%> (ø)
pkg/plugin/framework/common/plugin_kinds.go 0.00% <0.00%> (ø)
pkg/plugin/framework/server.go 0.00% <0.00%> (ø)
...k/backupitemaction/v2/backup_item_action_server.go 33.06% <33.06%> (ø)
...kupitemaction/v2/restartable_backup_item_action.go 65.21% <65.21%> (ø)
...reitemaction/v2/restartable_restore_item_action.go 67.10% <67.10%> (ø)
pkg/plugin/clientmgmt/manager.go 80.08% <88.88%> (+2.68%) ⬆️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Scott Seago <sseago@redhat.com>
@github-actions github-actions bot removed the Area/Design Design Documents label Jan 10, 2023
@sseago sseago marked this pull request as ready for review January 10, 2023 21:27
@Lyndon-Li Lyndon-Li self-assigned this Jan 16, 2023
@shubham-pampattiwar shubham-pampattiwar merged commit cf2b482 into vmware-tanzu:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RestoreItemAction v2 API
4 participants