Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix controller problematic log output #5572

Merged
merged 1 commit into from Nov 9, 2022

Conversation

qiuming-best
Copy link
Contributor

@qiuming-best qiuming-best commented Nov 9, 2022

Signed-off-by: Ming mqiu@vmware.com

Thank you for contributing to Velero!

Please add a summary of your change

  • Upgrade controller-runtime to v0.12.2
  • Implement String function for PeriodicalEnqueueSource

Does your change fix a particular issue?

Fixes #(issue)
fix #5571

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@github-actions github-actions bot added the Dependencies Pull requests that update a dependency file label Nov 9, 2022
Signed-off-by: Ming <mqiu@vmware.com>
@codecov-commenter
Copy link

Codecov Report

Merging #5572 (bf1122b) into main (5c98e88) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #5572      +/-   ##
==========================================
+ Coverage   40.90%   40.92%   +0.01%     
==========================================
  Files         239      239              
  Lines       20624    20629       +5     
==========================================
+ Hits         8437     8442       +5     
  Misses      11570    11570              
  Partials      617      617              
Impacted Files Coverage Δ
pkg/util/kube/periodical_enqueue_source.go 67.30% <0.00%> (-7.17%) ⬇️
pkg/uploader/provider/kopia.go 56.91% <0.00%> (+4.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@blackpiglet blackpiglet merged commit cd37141 into vmware-tanzu:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file has-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

velero problematic output logs for controllers
4 participants