Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prometheus metrics to record warning total and last status of backups #5779

Merged
merged 1 commit into from Jan 31, 2023

Conversation

allenxu404
Copy link
Contributor

Thank you for contributing to Velero!

Please add a summary of your change

  • add metrics backup_warning_total for record of total warnings
  • add metrics backup_last_status for record of last status of the backup

Does your change fix a particular issue?

Fixes #5380 #5398

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2023

Codecov Report

Merging #5779 (a5a165b) into main (598333d) will decrease coverage by 0.05%.
The diff coverage is 37.50%.

@@            Coverage Diff             @@
##             main    #5779      +/-   ##
==========================================
- Coverage   40.67%   40.62%   -0.05%     
==========================================
  Files         243      244       +1     
  Lines       21035    21263     +228     
==========================================
+ Hits         8555     8638      +83     
- Misses      11857    12000     +143     
- Partials      623      625       +2     
Impacted Files Coverage Δ
pkg/controller/backup_controller.go 55.64% <37.50%> (-0.20%) ⬇️
pkg/persistence/object_store.go 53.09% <0.00%> (-3.10%) ⬇️
pkg/podvolume/restorer.go 9.09% <0.00%> (-2.48%) ⬇️
pkg/plugin/framework/action_resolver.go 5.00% <0.00%> (-0.76%) ⬇️
pkg/util/kube/pod.go 0.00% <0.00%> (ø)
pkg/plugin/framework/server.go 0.00% <0.00%> (ø)
pkg/podvolume/restorer_factory.go 0.00% <0.00%> (ø)
pkg/plugin/framework/common/plugin_kinds.go 0.00% <0.00%> (ø)
...reitemaction/v2/restartable_restore_item_action.go 67.10% <0.00%> (ø)
pkg/plugin/clientmgmt/process/client_builder.go 94.59% <0.00%> (+0.15%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

pkg/metrics/metrics.go Outdated Show resolved Hide resolved
…kups

Signed-off-by: allenxu404 <qix2@vmware.com>
@qiuming-best qiuming-best merged commit 5156852 into vmware-tanzu:main Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add velero_backup_warning_total metric
4 participants